View controller not switching after override of tabBar willSelect

Question

View controller not switching after override of tabBar willSelect

Closed this issue 7 years ago · 5 comments

This is a continuation of issue #67.

I am not able to implement func tabBar(tabBar: TabBar, willSelect tabItem: TabItem) without overriding it. I can however implement func tabBar(tabBar: TabBar, didSelect tabItem: TabItem) without overriding that one.

The problem is when I override willSelect my view controller no longer transitions.

Answer 1 · 2017-10-10T04:15:29.000Z

Hi @tomdaniel0x01
Can you elaborate on the issue?
Are you calling super.willSelect(...) in your override of the willSelect?

Answer 2 · 2017-10-10T14:15:08.000Z

I am going to issue an update for this, which will have Material use an internal delegate and the external will be for adopters of the TabsController and TabBarDelegate :)

Answer 3 · 2017-10-10T16:36:57.000Z

@mohpor calling super.willSelect(...) did the trick! Thank you.

@DanielDahan I do think that would make for cleaner/easier usability of TabsController and TabBarDelegate.

Answer 4 · 2017-10-10T16:37:28.000Z

I am about to make a push right now :) @tomdaniel0x01

Answer 5 · 2017-10-10T16:45:51.000Z

This has now been released in Material 2.11.0 :)