CosmicMind/Samples

I met "compile error" when I built samples

guoyingtao opened this issue · 11 comments

guoyingtao commented

I found the samples were still for swift 3.
Is it convenient for you to update them for swift 4? Thank you!

daniel-jonathan commented

Yes, and if you know which ones you had trouble with, please add them to this issue :)

guoyingtao commented

Like Transitions and TransitionsWithIdentifier

daniel-jonathan commented

I updated those two projects. If you find anymore, please let me know :) Thank you!

wdcurry commented

CollectionView has 15+ errors on compile.

daniel-jonathan commented

@wdcurry sorry for the delay, let me take a look.

wdcurry commented

No worries, i know this is all volunteer efforts, and your library is massive, thanks!

daniel-jonathan commented

@wdcurry You will want to use this commit: 2aa73721d12e0ffea5bce98432a3d6aefdea5e5f for Material, and pull the latestSamples repo.

Let me know if there are any further issues :)

wdcurry commented

Thanks! a quick refresher: download zip, "pod install" in root, build ok. Should we need to do anything more? I ask as i am getting a runtime error on startup:
"Could not cast value of type 'UICollectionViewFlowLayout' (0x10a613ca0) to 'Material.CollectionViewLayout' (0x10773d798).
2017-12-04 12:37:34.770224-0400 CollectionView[14265:1642531] Could not cast value of type 'UICollectionViewFlowLayout' (0x10a613ca0) to 'Material.CollectionViewLayout' (0x10773d798)."

I have not converted to Swift4 as i had to do in prior samples.

Thanks, and hopefully this question helps others.

daniel-jonathan commented

@wdcurry when you do a pod install you are installing the master branch. I put the fix on a commit and once I go through the issues today, I will make a release, which will allow you to use the master branch as you are.

wdcurry commented

oh crap, sorry, brainfart here ;) I will leave that comment here for comedic relief ;)