Not all the tests run on Linux

Question

Not all the tests run on Linux

Closed this issue 4 years ago · 3 comments

wacumov commented 4 years ago

Test cases that do not run on Linux:

testMixedReadByte
testMixedReadBytes
testReadBytesThrowsBeforeReading
testReadBitsThrowsBeforeReading
testBool

Answer 1 · 2020-10-18T20:20:08.000Z

Hi @wacumov!
it looks like, i forgot to add those tests to the allTests array.
Wouldn't this help to fix the issue?

I took a look into your PR but was not sure what's going on Linux 😅

Thanks!

Answer 2 · 2020-10-19T12:06:36.000Z

Hi @Cosmo! Yes, some test cases are missing on Linux. I've fixed it in the PR and have added LinuxVerificationTests to prevent such a situation in the future.
Here you can see that 20 test cases run on Linux and 21 on Mac OS (20 from allTests + 1 from LinuxVerificationTests)

Answer 3 · 2020-10-19T12:20:41.000Z

Oh, I see -- smart! :D
Thanks a lot!