Bug Report: Upscale only updates some tiles
caretakerscurse opened this issue · 8 comments
I'm having a very strange issue with Ultimate SD Upscale. I have tried searching for anyone also having the issue but can't seem to find anything. Maybe my googlefu is just lacking.
Here I just rendered a simple image at 512x using toonyou_beta6 and mostly default settings.
I send this output to image2image, select the USDUpscale script, set scale of 2, Upscaler to R-ESRGAN 4x+ Anime6B (I have tried others, same results). Everything else is unchanged.
For the sake of this example I have the Denoising Strength set to 1 so any changes are very clear. This is what I get out.
You can see that the first tile is completely changed, as expected. The second block is mostly changed, but the top of this tile is not (this is consistent on every upscale that I have done). The remaining two blocks are just the OG image. No changes other than the edges that touch the first two tiles.
I do not understand what's causing this, nor can I find any other posts reporting the same issue. I've tweaked just about every setting I can think of, but my output always has this same error. Even using Chess as the type, the same areas are unchanged.
Thank you for anyone who took the time to read this. I'm sorry if I've wasted your time here and there is something I am doing wrong. I have included extra information below including sysinfo and the term output.
Scale factor: 2
Upscaling iteration 1 with scale factor 2
Tile size: 512x512
Tiles amount: 4
Grid: 2x2
Redraw enabled: True
Seams fix mode: NONE
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 20/20 [01:13<00:00, 3.68s/it]
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 20/20 [01:13<00:00, 3.68s/it]
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 20/20 [01:13<00:00, 3.69s/it]
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 20/20 [01:13<00:00, 3.69s/it]
Total progress: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████| 80/80 [04:56<00:00, 3.70s/it]
Total progress: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████| 80/80 [04:56<00:00, 3.68s/it]
I have now tried to reinstall USD Upscale as well reinstall A1111 completely, save for the models. Still have the same issue.
24/10 is the last time that i used this with perfect results.
look how is exactly the same problem, only the first tile + 90% of the entire first line is working
here is 256p in tile width.
and here is with chess in the pattern type (every other image was in Line pattern type)
well, here is fine... but with pattern type set to None, what means that ultimate upscale did nothing, its just resized.
@GothWave I'm sorry you're also having the issue but I'm relieved to see someone also having the same issue. I felt crazy.
What hardware are you working with? My setup was an RX7600
My is an RX6600, ryzen 5. The problem is that on 24/10 it was working, so it is something related with a new commit. I will try to run an old version and use --no-half just to make sure (we have AMD, so if i need --no-half i would not be surprise)
edit: the last commit was on sep 9, so... yeah
uhh... its working? i guess...
(using --no-half, with 30% improved performance(?). damn amd)
edit:
i forgot to use controlNet as i learned in this video (https://youtu.be/3z4MKUqFEUk)
now, with controlNet on tile_resample, using denoise 0.2 i can get it to work. The problem is that because i'm using now --no-half, i get a lot of OutOfMemory errors, so i am using a tile width of 400p.
i hope that it works for you too
Yep. That seem to fix it. I hate having --no-half on because of all the memory errors, but at least it works. Good find.
Hopefully someone with more know how then us can use this to patch accordingly (if that's even possible).
I'll leave this report open and let the maintainers make the call on what to do about it.
My SD have this problem too.
I use directml. this
I don't use any other extensions
txt2img has no problem
model is AOM3B2_orangemixs
sysinfo-2024-01-01-05-52.json
I've been running into this problem to this day, and I'm unsure what exactly causes it.
I'm using sd-ultimate-upscale in combination with control net tile-resample. Sometimes this works, sometimes it doesn't, really weird. I've also added in ADetailer at certain points, which sometimes works as well and sometimes doesn't -.-
I'm retrying now with the --no-half argument and see what happens…