CrackerakiUA/ui-cropper

Allow propagation

ViieeS opened this issue · 5 comments

ViieeS commented

I try to use uiCropper and ui.bootstrap.contextMenu together.

<div context-menu="$ctrl.contextMenu">
        <ui-cropper
                image="$ctrl.image"
                result-image-format="image/jpeg"
                area-type="rectangle"
                init-max-area="true"
        ></ui-cropper>
</div>

The problem is after menu opened it doesn't close with left or right click because of this line:

ui-cropper/compile/unminified/ui-cropper.js

Line 2507 in 9c26040

e.stopPropagation();

@CrackerakiUA, can you please explain why we use it here? Maybe we can allow event propagation optionally?

CrackerakiUA commented

we need it there, try to handle bootstrap click above ui-cropper

CrackerakiUA commented

if you can't handle, you can add option to disable it, so by default it should be enabled. PR are welcome, just update also docs

ViieeS commented

@CrackerakiUA I've created PR, but I didn't get where to update the docs. I've added description to PR.

ViieeS commented

@CrackerakiUA actually it's not clear for me how to create PR on the wiki. I've create a new repo and made changes here: https://github.com/ViieeS/ui-cropper-wiki.

Also, please make npm publish the latest version of ui-cropper. Thanks.