CravateRouge/bloodyAD

module "setGenericAll" remove permissions does not work

Closed this issue · 3 comments

The "setGenericAll" module with flag "enable" set to "False" does not work for me. After adding the permissions them with the module it is not possible to remove them.

ace_haspriv = ace['Ace']['Mask'].hasPriv(access_mask)

"ace_haspriv" is always "false" here.

Therefore the remove is never reached.

existing_ace['Ace']['Mask'].removePriv(access_mask)

Also this path is not taken, if the permissions are added twice.

LOG.warning(f"[!] {identity} already has this right on {target}")

Try with v0.1.8 I changed a lot of things regarding security descriptor modifications in db27fa9

tested it on friday :D
works now, thanks a lot!

Haha yes it can change very quickly

Great news! If you notice anything else don't hesitate to raise an issue or to make a suggestion.