Block pushes to master with failing CI
janheinrichmerker opened this issue · 8 comments
To keep the master branch healthy, would you consider protecting the master branch?
You can read more about it here: https://help.github.com/en/articles/about-protected-branches
That's a fine idea.
What do you think of the rule in the screenshot?
I checked Require review from Code Owners and Include administrators.
I would rather be a bit more strict.
In particular you could check "Dismiss stale PRs", "Require review from code owners" and "Include administrators".
I would rather be a bit more strict.
In particular you could check "Dismiss stale PRs", "Require review from code owners" and "Include administrators".
Done. 👌
Very nice. Now meeting into Master should be safe thanks to code review and CI checks 👍
Is there a reason why you didn't check "Dismiss stale PRs"?
I checked Dismiss stale pull requests. The last screenshot is outdated.
Here is one I just took a few seconds ago. 😅
Just perfect 👏