crashes with wynntails
Aces-and-Jacks opened this issue · 13 comments
incompatible with the Wynntils mod
There is nothing I can do about it. For some reason their mod does not work alongside CreativeCore. You should probably report the issue to them.
Just wondering do you still update the 1.12.2 version of this mod? cause there's an issue with wyntils on 1.12.2 as well I think
Also they said that it's creativecore's issue...so for now I guess creativecore will remain incompatible with wynntils
There is nothing I can do about it. For some reason their mod does not work alongside CreativeCore. You should probably report the issue to them.
"Some reason": CreativeLoaderFabric overwrites Forge EventBus classes, for whatever reason to make their mods work. Wynntils uses a genuine version of EventBus, shaded and transformed into the mod, along with Architectury to support Forge and Fabric. This means that this is in fact your issue, as you are the one overwriting a whole package of Forge.
@kristofbolyai Oh good to know. It's hard to figure out what is going wrong if there is no crash at all. CreativeCore does the same thing, provides a loader for both forge and fabric. That is why it shades @Cancelable and Event. I guess an easy way to fix it @Aces-and-Jacks is to open the creativecore jar file and remove all files inside net/minecraftforge/eventbus or just use forge. I do not see a different way to get around this issue, unfortunately.
@kristofbolyai Oh good to know. It's hard to figure out what is going wrong if there is no crash at all. CreativeCore does the same thing, provides a loader for both forge and fabric. That is why it shades
@CancelableandEvent. I guess an easy way to fix it @Aces-and-Jacks is to open the creativecore jar file and remove all files insidenet/minecraftforge/eventbusor just use forge. I do not see a different way to get around this issue, unfortunately.
But, your event class. It is not complete. What if you actually bundle forge event bus? That would make it so you have those classes, and won't conflict with other mods
Have you included the entire eventbus jar inside your workspace or do you just copy the files?
Have you included the entire eventbus jar inside your workspace or do you just copy the files?
It is fully included. All in all, we actually use it in fabric too, as we don't depend on Forge/Fabric APIs, so we have our own events with mixins.
Ok will do that!
@Aces-and-Jacks can you test this version here?https://www.dropbox.com/s/rg7u8a8x0logxyn/CreativeCore_FABRIC_v2.10.4_mc1.19.3.jar?dl=1
@Aces-and-Jacks can you test this version here?https://www.dropbox.com/s/rg7u8a8x0logxyn/CreativeCore_FABRIC_v2.10.4_mc1.19.3.jar?dl=1
I had to test this because our fabric build has a "breaks" with CreativeCore. I can confirm it loads and it loaded ItemPhysics too (as a test). Let me know when you release this version so I can remove the "breaks" tag from our mod.
I would recommend using 6.0.+ as the EventBus version to get non-breaking fixes for it in CreativeMD/CreativeLoaderFabric@b2c231a#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7.
Has been released and should be available in a few minutes.
@kristofbolyai thank you so much for your help!
Edit also changed it to 6.0.+ as you suggested.