Creatoon/Jar-web-app

Loader shows up in some parts of the application when ajax request completes

Opened this issue · 10 comments

Describe the bug
In many parts of the application where an ajax request is being made, there is a loader to show like your request is being processed, now there is no error handling for the request failure case -> Request gets failed but the loader is still showing up.

To Reproduce

  1. Go to http://52.66.208.178:9876/me
  2. Click on the upload photo button
  3. see error and loader

Expected behaviour
The loader should have stopped after the error comes.

Screenshots

Screenshot from 2021-08-20 18-10-24

Screenshot from 2021-08-20 18-10-28

I am unable to replicate the issue, what should I do?

@AbhijithGanesh what errors you are getting ?

I am not getting the loader itself

image
Loader isn't there at all

Click on change photo button -> select photo -> click on update button, you will see a loader on the update button itself

Understood the Issue, working on it.

The asynchronous error is related to AWS which I am not familiar with, It says specific bucket is not valid, it is related to the API which axios sends I suppose. Can you please help?

You don't have care about aws, you just have find its error handling.
Which will be like this
Catch(err){}
In this you have remove the loader just

I did that yet it shows the specified bucket is not valid error? I will make a PR soon

Make the pr, I will review it