CrossGeeks/PushNotificationPlugin

Android DefaultPushNotificationHandler "silent" flag not case sensitive

bPoller2810 opened this issue · 0 comments

The DefaultPushNotificationHandler for Android in method "void OnReceived(IDictionary<string, object> parameters)" does a calue check in line 151 for the key "silent". The Values to be a valid silent Notification are "true" and "1".

in my Case the resulting Value was "True" and the Handler resulted in unexpected behaviour.

This check should be made case sensitive (either with one more check or a "ToLower()" )

To the Maintainers:

  • Is this something you would consider a improvement?
  • Would you like to implement this for yourself or do you prefer a PullRequest?

PS: i should not forget to mention: if the app is in background this "behaviour" freezes the Android app completly. (a exception only occured 1 out of ~60 tests for me)