Modifier cleanup needs improvement
Opened this issue · 3 comments
lukemelia commented
Currently, the modifier calls floating-ui's autoUpdate
in its modify
method, which will run whenever an input changes. The method captures the cleanup function that autoUpdate
returns and registers it as a destructor, but that can still result in multiple autoUpdates being registered.
Instead, the modifier should capture the last cleanup method and call it at the beginning of the modify method, if present. (There will be none captured the first time the modifier instance runs.)
NullVoxPopuli commented
Ye, i'd like to see a function-modifier implementation
NullVoxPopuli commented
fwiw, I'm continuing development over in https://ember-primitives.pages.dev/
NullVoxPopuli commented
Resolved in universal-ember/ember-primitives#380