CrowdStrike/ember-velcro

D3 support (investigate)

nicolechung opened this issue · 1 comments

Mostly writing this as a reminder to myself (will try to open a branch to investigate this)

  1. We support SVGs in the code, but SVG doesn't (I think) have getBoundingClientRect. We should look into https://developer.mozilla.org/en-US/docs/Web/API/SVGGraphicsElement/getBBox.
  2. Some folks are using a Point object, which seems to have only an x,y and width value.

todos

  1. Update the tests to reflect working with svg elements and maybe points (will look into this) for this.hook
    https://github.com/CrowdStrike/ember-velcro/blob/main/test-app/tests/integration/components/velcro-test.js

for getBoundingClientRect, it looks like it is supported:
image

(I use this on my tool over here: NullVoxPopuli/baobab-ram#2 where SVG is used here: https://github.com/NullVoxPopuli/baobab-ram/pull/2/files#diff-3faf330991c5619676b7e34455f77bd5561d1c90638c2328bac9adc84ce83f1dR25 (the idFor) )