CsJohnJJ/C-lack

Sample State & Schema

Closed this issue · 0 comments

cindyytong commented

Great work! Some nits:

  • In JS we camelCase not snake_case. In ruby we snake_case. Please update accordingly.

  • User:

  • add directMessageIds: [1,2,3] b/c users have many memberships which is polymorphic and can belong to channel or directMessage

  • Message:

  • remove channelId b/c it is possible the message can belong to a channel or DM. Add messageable_id

  • add replyIds: [1,2,3,4] and parentId: 1 (see comment below about schema)

  • Channel: can we update creator with admin to confirm to actual language used by slack. This should be global change throughout (i.e. schema)

Schema:

  • Messages: we need to account for replies to a message. Add column parentId which will refer to a top level message