Cubxity/UnifiedMetrics

[Fabric] Carpet mod conflict with MSPT calculation

itsmemac opened this issue · 1 comments

Issue : incorrect MSPT reporting to prometheus due to conflict with carpet mod and unified metrics

Server version : Fabric 1.17.1 (Latest)
Plugin version : unifiedmetrics platform fabric 0.3.2 (Latest)
Carpet version : fabric carpet 1.4.47 (Latest)

Mods in server : fabric api @0.40.1 , fabric language kotlin @1.6.3 , unifiedmetrics @0.3.2, carpet @1.4.47

Detailed Analysis :

The issue is with incorrect MSPT being forwarded to prometheus when carpet mod is present in the server.

Having carpet mod in server sets the MSPT to 1.00 min as per screenshot attached below and without carpet mod, the MSPT is
sent without any issues.

The issue starts to show up in grafana 2 minutes after the server startup is done

With Carpet Mod added to server
with carpet

Without Carpet Mod added to server
without carpet

How to replicate the issue

  1. Add unifiedmetrics and carpet mod to /mods folder
  2. Add job to prometheus server
  3. Start server
  4. wait for 2 minutes
  5. Check grafana for MSPT