Cyan4973/xxHash

Include crc64fast-nvme in benchmark

hongbo-miao opened this issue · 1 comments

It would be great to include crc64fast-nvme in the benchmark, thanks! ☺️
https://github.com/awesomized/crc64fast-nvme

Thank you for the suggestion. I took a look at the repository — the implementation is written in Rust, and includes a significant amount of unsafe code. This somewhat undermines the usual safety advantages of Rust, and also complicates integration into the existing benchmark and collision test suites, which are primarily designed around C code.

The performance numbers on the website are promising, particularly the SIMD variant, which appears to be within a 2× factor of XXH3. However, setting up a direct comparison would require substantial effort and time, with no clear guarantee of a successful integration — resources I currently cannot allocate.