UI: Badlisted tags are not colored in file details view
kam193 opened this issue · 2 comments
Describe the bug
I see that for some time, badlisted tags are not colored in the file details view, in on the top (they are usually colored in sections view). I'm sure it was working previously, I observed the change a few weeks ago. I'm not 100% sure it's always like this, but it's NOT about tags badlisted after analyzing a file (which is obvious they cannot be marked), but existing before, even for months. I haven't seen such a problem with allowlisted tags.
To Reproduce
Steps to reproduce the behavior:
- Upload a file that generates a badlisted tag.
- After finishing the submission, compare the summary page and file details view.
- Observe badlisted tags colored in the summary view, but not in the file details view.
Expected behavior
Badlisted tags are colored everywhere.
Screenshots
Here, both tags are badlisted. You can also see, that in the section view, tags are colored only in the detailed view for a source and not the first summary-like. I suspect this may be the source of confusion for the UI.
The summary view is handled correctly:
Environment (please complete the following information if pertinent):
- Assemblyline Version: 4.5.0.12, Badlist 4.5.0.5
- Browser: Firefox
Additional context
This might be coming down to some inconsistency at the API-level between the two endpoints for marking the tags verdicts:
/api/v4/submission/<sid>/file/<sha256>//api/v4/file/result/<sha256>/