CybercentreCanada/jupyterlab-sql-editor

Allow user to specify Trino Connection object conn and cur

mrhopko opened this issue · 5 comments

mrhopko commented

A user may want to specify their own Trino connection in a notebook and add this to the Trino configuration. Presently the Trino configuration does not allow specifying the conn and cur attributes.

cccs-jc commented

A user can configure the magic via %config, for example

%config Trino.host='localhost'
%config Trino.port=8080
%config Trino.httpScheme='http'
%config Trino.auth=None
%config Trino.user='the-user'

Are there missing options.

mrhopko commented

Catalog and schema could be included and would be useful given issues with the Trino python connection not persisting session info (such as USE catalog.schema).

cccs-jc commented

okay sounds good. I'll add these configurations. At least a user will be able to switch default catalogs using this approach. A stop gap until the library properly handles USE.

cccs-jc commented

added two additional configs to the magic

%config Trino.catalog="cat1"
%config Trino.schema="schema2"

cccs-jc commented

fixed