Validate if symlink edgecase still exist when indexing
oreenlivnicode opened this issue · 1 comments
oreenlivnicode commented
if isinstance(obj, str):
# TODO: This is a symlink. We should handle it.
# Only examples at the moment are for https://github.com/edgedb/edgedb-pkg
# E.g. https://github.com/edgedb/edgedb-pkg/blob/master/integration/linux/build/centos-8/action.yml
logger.debug(f"[-] Symlink detected: {content}. Skipping...")
return
This code block appears twice in indexer.py.
We should validate if this bug still exists, and if so, fix it.
alex-ilgayev commented
Even though the checks are in the indexer, the fix should be in the downloader (so I labeled accordingly).
I believe the bug still exists, as we did nothing in the downloader to handle symlinks.