Values from unknown datasets appear in results

Question

Values from unknown datasets appear in results

Closed this issue 8 years ago · 7 comments

SimonGreenhill commented 8 years ago

For some reason there are results with no dataset:

To replicate:

Dplace -> search
Select Indo-European
Click "view selected search criteria"
Click 'Search'

Answer 1 · 2017-03-17T15:17:05.000Z

Hm. Cannot reproduce. You may have to recreate the DB?

Answer 2 · 2017-03-17T15:17:50.000Z

This is on the main site -- but agree that it looks like a partial import.

Answer 3 · 2017-03-17T15:18:31.000Z

Oh, so that means I have already fixed that bug :)

Answer 4 · 2017-03-17T15:21:06.000Z

No, I think on the production server that's due to the weird way links to other societies have been handled. They were created by adding half-baken Society objects, with the same xd_id. Possibly a filter in the society search excluding societies with sources without a name is lacking ...

Answer 5 · 2017-03-17T15:23:08.000Z

The way I fixed it, though, means no dummy societies are created, thus no links to societies not in D-PLACE will appear (other than the eHRAF link and the chirila link which are handled again differently).

Answer 6 · 2017-03-17T15:29:15.000Z

Oh good -- closing now.

Answer 7 · 2017-03-17T15:30:27.000Z

One could argue that location and glottocode are also just variables, and the societies from SCCS and WNAI are already coded for these variables, so it makes sense they appear. But then the dataset should have a proper source - as it has now in https://github.com/D-PLACE/dplace-data/blob/master/datasets/index.csv