Wrong fps count

Question

Wrong fps count

Closed this issue 7 years ago · 3 comments

Hello, found this project in reddit.

One logic error I spotted is in game js. In the loop function you are using setTimeout(fn, fps) but fps is 60 so your loop will not run every 16 ms for 60fps) but every 60 ms (17fps)

Answer 1 · 2017-01-16T19:38:12.000Z

@andreasgruenh Thank you for submitting this issue! Indeed the refresh rate was not calculated correctly, and I patched it over here: 489b679#diff-ffadca4f8ebdae8ae4da9f6cc17b62d3R14

Answer 2 · 2017-01-16T19:54:59.000Z

You should use the fps property in your refresh rate property :P or remove the fps property.

Answer 3 · 2017-01-16T20:11:58.000Z

Yes I just changed it :-)