DATA-DOG/go-sqlmock

CSVColumnParser returns []byte instead of driver.Value

vasyvasilie opened this issue · 1 comments

Operating system and Go Version

linux, 1.18.4

Issue

In 2018 this bug already appeared and was fixed in #140 v2 branch only, but last commit of v2 was on 14 Sep 2018
Can you support same behaviour in master?

Reproduction steps

https://go.dev/play/p/J5GC6fgNrYv

Expected Result

there is a remaining expectation which was not matched: ExpectedQuery => expecting Query, QueryContext or QueryRow which:
  - matches sql: 'SELECT '
  - is without arguments
  - should return rows:
    row 0 - [[49 50 51] <nil>]

Actual Result

there is a remaining expectation which was not matched: ExpectedQuery => expecting Query, QueryContext or QueryRow which:
  - matches sql: 'SELECT '
  - is without arguments
  - should return rows:
    row 0 - [[49 50 51] []]

Hi @vasyvasilie! Thank you for the great report ❤️ From what I see it's fixed in fd971de and it no longer reproduces, so closing. But please, feel free to reopen if this happens again!