General verification and clean-up of features C-1 to C-30
Closed this issue · 3 comments
codaich commented
- Go through each feature in manual
- Make sure feature descriptions are clear and complete
- Rename features to make clearer if need be
- Clean up code for each feature
- Adjust name and description metadata to match manual if necessary
- Standardize code formatting
- Clean up code documentation
- Adjust code for clarity
- Validate feature implementations
- Make sure what they calculate matches the manual specification
codaich commented
If rename any of the features, make sure to adjust feature dependency names as well. For reference, dependencies are as follows:
- 52 Most Common Vertical Interval -> Wrapped Vertical Interval Histogram
- 53 Second Most Common Vertical Interval -> Wrapped Vertical Interval Histogram
- 53 Second Most Common Vertical Interval -> Most Common Vertical Interval
- 54 Distance Between Two Most Common Vertical Intervals -> Most Common Vertical Interval
- 54 Distance Between Two Most Common Vertical Intervals -> Second Most Common Vertical Interval
- 55 Prevalence of Most Common Vertical Interval -> Wrapped Vertical Interval Histogram
- 55 Prevalence of Most Common Vertical Interval -> Most Common Vertical Interval
- 56 Prevalence of Second Most Common Vertical Interval -> Wrapped Vertical Interval Histogram
- 56 Prevalence of Second Most Common Vertical Interval -> Second Most Common Vertical Interval
- 57 Ratio of Prevalence of Two Most Common Vertical Intervals -> Prevalence of Most Common Vertical Interval
- 57 Ratio of Prevalence of Two Most Common Vertical Intervals -> Prevalence of Second Most Common Vertical Interval
- 58 Unisons -> Wrapped Vertical Interval Histogram
- 59 Vertical Minor Seconds -> Wrapped Vertical Interval Histogram
- 60 Vertical Thirds -> Wrapped Vertical Interval Histogram
- 61 Vertical Tritones -> Wrapped Vertical Interval Histogram
- 62 Vertical Fifths -> Wrapped Vertical Interval Histogram
- 63 Vertical Octaves -> Vertical Interval Histogram
- 64 Fraction of Minor Vertical Intervals -> Wrapped Vertical Interval Histogram
- 65 Fraction of Major Vertical Intervals -> Wrapped Vertical Interval Histogram
- 66 Perfect Vertical Intervals -> Wrapped Vertical Interval Histogram
- 67 Vertical Dissonance Ratio -> Vertical Interval Histogram
- 67 Vertical Dissonance Ratio -> Wrapped Vertical Interval Histogram
- 68 Chord Duration -> Chord Type Histogram
- 69 Partial Chords -> Chord Type Histogram
- 70 Complex Chords -> Chord Type Histogram
- 71 Standard Triads -> Chord Type Histogram
- 72 Diminished and Augmented Triads -> Chord Type Histogram
- 73 Dominant Seventh Chords -> Chord Type Histogram
- 74 Seventh Chords -> Chord Type Histogram
- 75 Non-Standard Chords -> Chord Type Histogram
- 76 Minor Major Triad Ratio -> Chord Type Histogram
codaich commented
Remember to alwasy account for the possibility of a null sequence_info