Conflict with Status Icon Counters
crcoughenour opened this issue · 2 comments
Describe the bug
An error is received, "name: may not be undefined", when attempting to use a Token Status Effect that was added by DFreds Convenient Effects while the Status Icon Counters module is also enabled.
Both modules work independent of the other. That is to say, custom statuses work with just DFreds Convenient Effects and Status Icon Counters work on out-of-the-box statuses.
To Reproduce
- Install and enable DFreds Convenient Effects, Status Icon Counters, and any dependencies.
- Configure Game Settings > DFreds Convenient Effects > Modify Status Effects > Set to Add or Replace.
- Attempt to apply Token Status Effect added by DFreds Convenient Effects (Convenient Effects UI or Token HUD).
Expected behavior
The effect should be applied. (Convenient Effects UI or Token HUD)
When clicked again via the Convenient Effects UI, the effect should be removed. Aside: Although it might be nice to add some mechanism to remove OR increment the Status Icon Counter from this context.
When applied multiple times via the Token HUD, Status Icon Counters will increment a counter for the number of stacks of the effect.
When removed via the Token HUD, Status Icon Counters will decrement the counter for the number of stacks of the effect, removing at zero stacks.
Screenshots
Additional context
Foundry v11.305
DnD5e v2.2.2
DFreds Convenient Effects v5.0.3
Status Icon Counters v2.0.17
This happens because effects created by this module no longer have the label property, which is deprecated in v11. I'll provide a fix on my end using the newer name. However, you might still want to consider keeping the property until it is officially removed from FVTT core.
Thank you so much!