Convenient effects doesn't always play nice with Multi Token Status
Closed this issue · 3 comments
Description:
A module conflict with Multi Token Status (https://github.com/cs96and/FoundryVTT-multistatus).
When Multi Token Status is enabled, activating the Invisible status through token controls applies the invisible dynamic effect but not the visual effect on the token. Tokens given the invisible status via token controls can still be seen by all players.
Tokens made invisible by the convenient effects window are affected as expected.
To Reproduce:
Steps to reproduce the behavior:
- Activate both Convenient Effects and Multi Token Status
- Right click a token, click on statuses, activate the Invisible effect
- The icon for invisible appears on the token, the active effects apply to the character sheet, but the token remains visible to all players.
Expected Behavior:
Upon assigning the status from the token's status menu, the token should fade and become invisible to other players.
Screenshots:
With Multi Token Status enabled
With Multi Token Status Disabled
The workaround
Additional Context:
The console window doesn't output any error codes. It seems like it's a visual bug only, but it does affect game for the invisibility use case.
I'm not sure what other data could be useful here, but let me know and I'll provide what I can. Thanks for your time!
It's likely because we both override TokenHUD.prototype._onToggleEffect. If you open up the libWrapper settings menu, you should be able to prioritize one over the other or see what the conflicts are. Ultimately, I'm not sure there is much I can do here as I have to override this function.
I'll wait for your findings before closing this
With Convenient effects prioritized, we lose multi token status' functionality and get this warning.
With Multi Token Status prioritized, we lose the visual effects of invisibility and get this warning.
Functionally, it's not quite the same as disabling the mods. If it's unfixable, that's not a huge loss. The big workaround is just to select statuses from the convenient effects window instead of the token menu, which works for me.
Even if it can't be fixed, I'd like to thank you for looking into it. I appreciate the time!
So, Foundry STILL hasn't implemented a way for two modules to manipulate the status effects despite some feature requests. It isn't a supported API, so every module that does is patching it to do something, and they'll override each other. This can be revisited if and when Foundry adds this, or if a library is created which could somehow do this