Typo in sse2neon.h line 8029

[alant2020]

Hi,

there seems to be a typo in sse2neon.h: Lines 8029 and 8030 should be "connected", e.g. with an "&&" or "||"?

8029: #if defined(SSE2NEON_HAS_BITSCAN64)
8030:    (defined(_M_AMD64) || defined(__x86_64__))

Thanks a lot!

Greetings,
Alan

[jserv]

hi @alant2020 , you are right. Please send a pull request to resolve this.

[alant2020]

Sorry, can't create a pull request. Do not know what exactly would be the correct fix.

[jserv]

Sorry, can't create a pull request. Do not know what exactly would be the correct fix.

Please check https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

[alant2020]

@jserv thanks for the link. However, the question is rather:

What's the correct fix for the source code: joining the lines 8029/8030 with "||" or "&&" or something completely different?

[aqrit]

just delete line 8030

the definition of SSE2NEON_HAS_BITSCAN64 already checks for x64

sse2neon/sse2neon.h

Line 113 in 7b92098

#ifdef _MSC_VER

edit: however, it looks like the MSVC requires defined(_M_ARM64) for _BitScanForward64 ...
so

sse2neon/sse2neon.h

Line 116 in 7b92098

(defined(_M_ARM) || defined(__arm__))

is also wrong.