Incorrect DriveCollection.yaml reference to Swordfish in json-to-openapi-convertor
mick-jones-vertiv opened this issue · 3 comments
References to incorrect (and deprecated) Swordfish DriveCollection.yaml schema in "openapi.yaml" due to superflous "if" statement in "json-to-yaml.py" on line 271. Remove the condition to use DMTF version of DriveCollection.yaml in references.
This issue prevents successful generation of client or server stub using openapi-generator as the OAS spec does not validate successfully.
Refer to forum post: https://redfishforum.com/thread/384/openapi-code-generation
@mraineri Mike - happy to fix it if you give me the right permissions to create a branch and PR. (Actually fixed it and tested it on my local already, not really any kind of challenge :-) )
You can always make a fork of the repo and do a PR that way (that's what most users end up doing), but I've actually made a PR already too :)
OK, thanks for the tip. I was wondering if the fork option was the way to go so now that's confirmed for the future. I'll leave it to you then and look around for something more substantial. 👍