DMTF/spdm-dump

The expression 'pcap_packet_header.incl_len' needs to be clear

Closed this issue · 1 comments

Passing expression pcap_packet_header.incl_len to fread, which uses it as an offset.
pcap_packet_header.incl_len is an uncertain value, which may cause m_pcap_packet_data_buffer to be affected line 141.

if (fread(m_pcap_packet_data_buffer, 1,
pcap_packet_header.incl_len,
m_pcap_file) != pcap_packet_header.incl_len) {
return;
}
dump_pcap_packet(m_pcap_packet_data_buffer,
pcap_packet_header.incl_len);

same issues:
m_pcap_global_header.snap_len needs to judge the range.

m_pcap_packet_data_buffer =
(void *)malloc(m_pcap_global_header.snap_len);
if (m_pcap_packet_data_buffer == NULL) {
printf("!!!memory out of resources!!!\n");
return false;
}

I will check it.