8.2.0 seems to still be reliant on Telerik dependancies
Opened this issue · 5 comments
Describe the bug
Software Versions
- DNN: 9.11.00 and 9.11.2
- Module: 8.2.0
To Reproduce
Steps to reproduce the behavior:
- Install DNN Vendors 8.2.0 on 9.11.x
- Go to the Vendors pages it creates (typically /admin/vendors)
- You will likely see this error
Expected behavior
8.2.0 should be Telerik-free
Screenshots
If it helps, I did notice that when installing the module, the release notes look like this:
It looks like it's still installing 8.1.0?
Installing a 9.11 site that has never had DNN Vendors looks like this:
StartJob Starting Installation
Info Starting Installation - DotNetNuke.Vendors
Info Starting Installation - Script
Info Begin Sql execution
Info Folder Created - C:\Inetpub\vhosts\fakedomain.com\httpdocs\DesktopModules\Vendors\Providers\DataProviders\SqlDataProvider
Info Created - Providers\DataProviders\SqlDataProvider\08.00.00.SqlDataProvider
Info Executing 08.00.00.SqlDataProvider
Info Start Sql execution: 08.00.00.SqlDataProvider file
Info End Sql execution: 08.00.00.SqlDataProvider file
Info Created - Providers\DataProviders\SqlDataProvider\Uninstall.SqlDataProvider
Info Finished Sql execution
Info Component installed successfully - Script
Info Starting Installation - Module
Info Module registered successfully - Vendors
Info Component installed successfully - Module
Info Starting Installation - Assembly
Info Assembly registered - bin\Dnn.Modules.Vendors.dll
Info Created - bin\Dnn.Modules.Vendors.dll
Info Component installed successfully - Assembly
Info Starting Installation - ResourceFile
Info Expanding Resource file
Info Created - 08.00.00.txt
Info Created - affiliates.ascx
Info Created - App_LocalResources/Affiliates.ascx.resx
Info Created - App_LocalResources/BannerOptions.ascx.resx
Info Created - App_LocalResources/Banners.ascx.resx
Info Created - App_LocalResources/DisplayBanners.ascx.resx
Info Created - App_LocalResources/EditAffiliate.ascx.resx
Info Created - App_LocalResources/EditBanner.ascx.resx
Info Created - App_LocalResources/EditVendors.ascx.resx
Info Created - App_LocalResources/Vendors.ascx.resx
Info Created - BannerClickThrough.aspx
Info Created - banneroptions.ascx
Info Created - banners.ascx
Info Created - banners.png
Info Created - displaybanners.ascx
Info Created - editaffiliate.ascx
Info Created - editbanner.ascx
Info Created - editvendors.ascx
Info Created - license.txt
Info Created - module.css
Info Created - releaseNotes.txt
Info Created - vendors.ascx
Info Resource Files created
Info Component installed successfully - ResourceFile
Info Starting Installation - ResourceFile
Info Expanding Resource file
Info Created - Dnn.Modules.Vendors.pdb
Info Resource Files created
Info Component installed successfully - ResourceFile
Info Starting Installation - Cleanup
Info Processing Cleanup File - 8.1.1
Info Completed Processing of Cleanup File - 8.1.1
Info Component installed successfully - Cleanup
Info Starting Installation - File
Info Creating backup of previous version - 08.00.00.txt
Info Created - 08.00.00.txt
Info Component installed successfully - File
Info Installation committed
Info Installation successful. - DotNetNuke.Vendors
Info Starting Installation - DotNetNuke.Banners
Info Starting Installation - Module
Info Module registered successfully - Banners
Info Component installed successfully - Module
Info Installation committed
Info Installation successful. - DotNetNuke.Banners
Info Deleted temporary install folder
EndJob Installation successful.
Error log
Note: Debug DLL's
Please replace the current extension DLL's with the debug DLL's (if these are available with the release) and reproduce the error with the debug DLL's before pasting the error log.
Paste the error log that is related to this issue.
Additional context
I have both done a upgrade as well as a clean install to test this.
On a DNN 9.7.2 version, I upgraded from Vendors 8.0.0 to 8.2.0, and then upgraded DNN to 9.11.0 and the module still used Telerik. I could see in the Telerik Identifier, that the Vendors dll was still being reported as being dependant on Telerik. I uninstalled the module complete, and then tried reinstalling and it still showed that it's dependent on Telerik.
On a separate website that is running DNN 9.11.0, I clean installed DNN Vendors 8.2.0 and I got the same error where "Could not load file or assembly 'DotNetNuke.Web.Deprecated' or one of its dependencies." on the Vendors page.
I can confirm this issue. I did a fresh install of DNN9.12 and installed the Dnn.Modeules.Vendors_v8.2.1.zip in Extensions. From what I can see, it is the same as the prior version. It is the wrong install.
If you open the Source code zip files, for 8.2, they are corrected.
I compared the Vendors.ascx file between 8.1, 8.2, and the version I submitted. The files from 8.1 and 8.2 for Vendors.ascx match and reference DotNetNuler.Web.UI.Depricated.
@valadas Can you fix this and publish the correct Install zip file?
I can confirm this issue as well. Did a fresh install of DNN 9.13 and installed Dnn.Modules.Vendors_v8.2.0 and found same error and notes as OP.
FYI - I just took a cursory look at the module, and it appears to need somewhat moderate updates to remove telerik completely.
Elements to Replace:
- 4 date pickers
- 1 grid
- 2 combo boxes (w/ type ahead autosuggest)
I may have missed 1-2 other things, but that's what it looks like as of right now.
@WillStrohl Those are the updates I made here: https://github.com/Marker4/DNN.Vendors/tree/master which were pulled in. I don't know what happened with the release. The Source code is correct with the changes to remove Telerik. The Asset Dnn.Nodules.Vendors_v8.2.0.zip is incorrect.
I ran a compare between Dnn.Nodules.Vendors_v8.2.0.zip and Dnn.Modules.Vendors_08.01.00_Install.zip. The files that were updated to remove Telerik were not updated. They are the same as they were for version 08.01.00.
@valadas can hopefully resolve this by rebuilding Dnn.Nodules.Vendors_v8.2.0.zip
@WillStrohl Those are the updates I made here: https://github.com/Marker4/DNN.Vendors/tree/master which were pulled in. I don't know what happened with the release. The Source code is correct with the changes to remove Telerik. The Asset Dnn.Nodules.Vendors_v8.2.0.zip is incorrect.
I ran a compare between Dnn.Nodules.Vendors_v8.2.0.zip and Dnn.Modules.Vendors_08.01.00_Install.zip. The files that were updated to remove Telerik were not updated. They are the same as they were for version 08.01.00.
@valadas can hopefully resolve this by rebuilding Dnn.Nodules.Vendors_v8.2.0.zip
@valadas Attempted build and got Error:
The 'addin' directive is attempting to install the 'SharpZipLib' package (TaskId:44)
1> without specifying a package version number. (TaskId:44)
It's not recommended, but you can explicitly override this warning (TaskId:44)
Not sure how to proceed.