DOI-USGS/EGRET

plotConcTime not working when generating eList using as.egret

raruggie opened this issue · 1 comments

I get the following error when using plotConcTime:

plotConcTime(eList)

Error in `$<-.data.frame`(`*tmp*`, Q, value = numeric(0)) : 
  replacement has 0 rows, data has 32

If eList is created using as.egret plotConcTime will not work. plotConcTime works with an eList that was created using mergeReport. The only difference I can see between the two eLists is that with mergeReport the flows are added to the Sample dataframe.

In R, traditionally the as. prefix to a custom object is a minimal function to check that the object is legit and gives it the proper structure/attributes (in this case our custom "eList" EGRET object). Since it is possible to do some EGRET analysis without a Sample data frame (using the flow analysis functions), I didn't want to put the "mergeReport" directly in the "as.EGRET" function.

That being said... I could add a check within the function to see if there's a complete Sample data frame and then do the mergeReport. So, I'll do that in the next couple of days and give you the instructions to try it out. Thanks!