DainDwarf/IncrementalEmpire

Horn of Plenty efficiency does not get updated when gaining mana

Closed this issue · 1 comments

It seems that when unlocking Click Power, and later gaining more mana, the Horn of Plenty efficiency does not get updated correctly and stays at 1

Please do a unit/acceptance test for it!

It's, like, right there: Forgot to put some dependant key in the computed macro:

ressourceSpellEfficiency: computed('clickPowerActive', function() {

Note for later: Be careful with the computed stuff! Explicit computed can fall for this! Prefer using specific macros when possible (filterBy, sum, and, ...), as they do not suffer this issue, and review more carefully the computed macro!