getModsFromSaves() returns jargon with larger mod sets

Question

getModsFromSaves() returns jargon with larger mod sets

Closed this issue 7 years ago · 11 comments

The code used:

factorioAPI.getModsFromSaves().then(list => {
    console.log("Mods used in save:");
    console.log(JSON.stringify(list))
    console.log(asTable(list[0].mods))
});

Answer 1 · 2017-11-05T16:46:10.000Z

I'm going to be very honest with you. The code for getting mods from a save file isn't actually mine. I found it somewhere and it worked (I forget where I found it), but it might be outdated and incompatible with 0.15. So I have no idea why it's not working and how to fix it. I'll look for a solution when I have got the time to do so.

Answer 2 · 2017-11-05T20:21:40.000Z

JARG had a lot at the error and said it looked like it was unzipped and then just returned the data as a string, which would explain why definitions from data.lua has become muddled in there.

Might help you debug.

Answer 3 · 2017-11-22T15:39:15.000Z

Fixed in #3

Answer 4 · 2017-11-22T15:39:48.000Z

The number of bytes between mods changed in Factorio version 0.15 from 4 to 8. I made a pull request correcting this and also corrected a little offset bug when reading the name, so it should no longer be needed to trim the name or remove non-ASCII characters.

BTW you might have found the original the same place i did https://forums.factorio.com/viewtopic.php?f=69&t=35644

Answer 5 · 2017-11-22T15:48:02.000Z

I merged your pull request, thanks a lot! I did indeed find the code from AlyxDeLunar. I didn't test anything or make any changes since 0.15 released, so I didn't know that it didn't work anymore.

Answer 6 · 2017-11-23T12:04:23.000Z

Sounds like we need unit tests, but good job on fixing this one 👍

Answer 7 · 2017-11-23T15:30:16.000Z

I did initially make unit tests, but they don't work very well, because of timeouts when it takes too long to download a mod.

Answer 8 · 2017-11-26T13:40:36.000Z

Using mocha, you can extend the timeout for specific tests. See for example line 104 of https://github.com/Danielv123/factorioClusterio/blob/f3bb8c58e56865c7b8643cd0d6454975d6c092ac/lib/fileOps.spec.js

or line 39 of https://github.com/Danielv123/factorioClusterio/blob/b847b1a934a73186b6ca455bd65f09f9c779af1c/master.spec.js

Answer 9 · 2017-11-26T13:43:20.000Z

Thanks! That's really useful.

Answer 10 · 2018-01-04T19:17:48.000Z

Using the latest package version on NPM (0.1.28) I still get the same error as when I created this issue. This is on a map generated in 0.15.37.

Should this issue be reopened?

Answer 11 · 2018-01-04T19:47:37.000Z

The last pull request was merged 1 month ago, but the last time I updated the package was 2 months ago. I might have forgotten to update the package.