DanielHindi/aws-s3-zipper

Corrupted zip file result in zipToS3File

Opened this issue · 0 comments

Hi Daniel,

I was getting corrupted zip files when using the aws-s3-zipper@1.3.0 with archiver version 0.21.*. The S3 bucket had around 3,500 images at about 1.8 KB each. I did not experience this on buckets with a small amount of images.

zipper.filterOutFiles = function(file){
				if(file.Key.indexOf('.zip') >= 0) // filter out zip files
					return null;
				else 
				  return file;
};
		  
zipper.zipToS3File({s3FolderName: `test`, s3ZipFileName: `test/export.zip`},(err,result)=>{
	if(err)
		reject(err);
	else{
		console.log(`Done: ${result}`);                                       
	}
});

After upgrading to the latest version aws-s3-zipper@1.3.1 (This is not on npm) and updating archiver to 3.1.1, i was no longer getting corrupted zip files.

Can we please upgrade the archive version to 3.1.1, forgive my ignorance - I am not sure if/what this will break in aws-s3-zipper as this is a 3 major version upgrade.

https://github.com/DanielHindi/aws-s3-zipper/blob/master/package.json#L7