DanielKeep/cargo-script

Code block manifest uses first doc comment *anywhere* in script

Closed this issue · 2 comments

The comment extraction is supposed to only allow a crate doc comment that is the first thing in the file after the hashbang. Currently, it doesn't enforce this. It should.

Fix would be to modify the search to abort if it finds anything that isn't whitespace.

durka commented

As a corollary to this, it fails with an internal error if there is no doc comment at all (but an empty //! satisfies it).

Urgh. What asshole wrote this garbage?