DanielMSchmidt/apollo-opentracing

Tracing requests without logging results

dchambers opened this issue · 4 comments

dchambers commented

H There, is there a way not to log the results as these will contain PII (Personally identifiable Information), which we're not allowed to log?

Thanks in advance.

dchambers commented

From looking at the code I can already see that this isn't currently configurable. Would you accept a PR to add support for a logResults flag in the options provided to the OpentracingExtension constructor?

  • 👍1
DanielMSchmidt commented

Hey @dchambers

Yeah, this is a feature on my bucket list that I haven't got to 😢

I think I would love to have some onRequestFinish and onFieldResolveFinish callbacks that get the result as an argument. Would it be possible for you to do a PR?

  • 👍1
dchambers commented

Hi @DanielMSchmidt, can you took a look at #157 which hopefully addresses this issue in the way you describe.

  • 🎉1
stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.