DanielMSchmidt/apollo-opentracing

Use tags instead of logs

cliedeman opened this issue · 3 comments

Things like this should likely be a tag instead of a log.
The rule of thumb I use is that things known at the start of the span should all be tags.

  • Add tags to snapshot serializer
  • log/tag variables
  • field resolver tags (fieldName, fieldType)

The graphql-go package has a good reference for tags

Good idea, let's do it 👍

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.