Mishandled windchill and temperature data from TFA wind sensor
Closed this issue · 2 comments
NateRobinsonS commented
In revision 0.17,0 (and earlier, I believe), the temperature data (attributes) sent by a TFA wind sensor is only reported correctly for values less than 0 degrees C. It appears that the issue is in the handling of the leading bit to detect integers less than zero.
I've modified code that works on my machine, and will attempt to submit a pull request. However, I am an expert in neither python nor GitHub.
Danielhiversen commented
It would be great if you could submit a pull request to fix this
NateRobinsonS commented
I believe I just submitted a PR against your fork. (It appears to be the
current version and that which gets distributed.) Let me know if it didn't
work, or if I chose the wrong base.
-Nate
On Wed, Apr 19, 2017 at 10:01 AM Daniel Høyer Iversen < ***@***.***> wrote:
It would be great if you could submit a pull request to fix this
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AX900DS-cUg7_biNaHcFIKBL7C7N78P3ks5rxb9PgaJpZM4M-R76>
.
--
…-Nate