[enhancement] Serialize and parse color codes, hex codes from placeholders

Question

[enhancement] Serialize and parse color codes, hex codes from placeholders

LcorpOfficial opened this issue 2 years ago · 21 comments

Currently all color codes are not serialized when imported to json, would be very cool to have this parse and translate the colors, or at the least filter the codes out of the output on the plugin end.

Answer 1 · 2022-05-07T08:53:08.000Z

Thanks for the suggestion! I've split this in two:

fix: remove formatting codes
feature: use formatting codes to display colours

The fix is available now already in version 1.7.2, the feature will have to wait until the next major release 🙂

Answer 2 · 2022-05-11T05:00:25.000Z

wonderful! that's gonna make this much nicer already!

Answer 3 · 2022-07-30T14:29:43.000Z

I'm now working on converting the formatting codes. Where does the format from your screenshot come from? Could you link me to some documentation maybe?

Answer 4 · 2022-07-30T20:46:28.000Z

It can come from either legacy & codes, from adventure Minimessage, or via the &#xxxxxx method usually. there is also the &x

method comes from the plugin EssentialsX and sometimes others that use MiniMessage, but idk what library they use, unfortunately.

Answer 5 · 2022-07-31T11:49:36.000Z

Thanks! I think I have all colour and formatting codes working correctly now. If you want, you can check first if it all works on your server before I mark the feature as done and merge it. It should be as easy as putting these files in the correct location:

If you use the internal web server, you can put them in plugins/WebStats/resources/WebStats-dist.js and plugins/WebStats/resources/style.css (create folder if it does not exist. These files do not get updated when you update the plugin so remember to remove them when you update the plugin)

Answer 6 · 2022-07-31T15:29:24.000Z

so far it seems as if it's working, the party name is using &#xxxxxx, nickname is using &9&l, and also tried with an &x gradient which should cover most Essentialsx/CMI/mcmmo-based stats

Answer 7 · 2022-07-31T15:31:12.000Z

Actually, it does seem to hide the colors' codes but the style isn't being applied for the colors. hmmmmmmm.

Answer 8 · 2022-07-31T15:37:34.000Z

There must be something wrong with the js file. Did you try hard-reloading (with ctrl+shift+r or ctrl+f5)?

EDIT: you can check if the right js file is active by seeing if entering webstats.display.constructor.convertFormattingCodes in the browser console gives a value

Answer 9 · 2022-08-01T23:24:37.000Z

ah I'll give it a try in the morning then! good point.

Answer 10 · 2022-08-19T09:46:36.000Z

Hi, did you get around to trying what I suggested? 🙂

Answer 11 · 2022-08-22T13:21:09.000Z

sorry! got busy with work

Answer 12 · 2022-08-22T18:55:24.000Z

No worries, I'm not in a hurry 😉

The new js file is not being served properly. It looks like you're using the internal web server, maybe you didn't place it in the correct location? (plugins/WebStats/resources/WebStats-dist.js)
Are you using version 1.7.2? Maybe you can try re-downloading the latest version: https://github.com/Dantevg/WebStats/releases/download/v1.7.2/WebStats-1.7.2.jar.
Otherwise, the only thing I can think of is that you may have saved the file as .js.txt? (Simple, yes, but who knows?)

Another way to check if the js file is being served is by going to ip:port/WebStats-dist.js and searching for convertFormattingCodes. Changing the js file should be directly visible there, no need to reload the plugin or server.

Answer 13 · 2022-08-22T20:10:10.000Z

I was using an older version, just updated to build but it doesn't seem to be there.

I did hotload the plugin so perhaps I'll need to do true reboot to see changes.

Answer 14 · 2022-08-22T20:12:44.000Z

Update: reboot to server did not change, it seems internal webserver doesn't accept the files. I'll try to also run a standalone

Answer 15 · 2022-08-22T20:17:23.000Z

Oh I see it, it's case-sensitive so it has to be WebStats-dist.js😅

(I now realise I could better have kept it all lowercase)

Answer 16 · 2022-08-22T20:32:29.000Z

hahaha, either way, I noticed that on local. upon running a local server I get this in console

EDIT this is present when getting the js to load on internal server as well

Uncaught TypeError TypeError: Cannot read properties of undefined (reading 'colour')
    at parseFormattingCode (x:\inetpub\wwwroot\audio\webstats-dist.js:419:18)
    at parseFormattingCodes (x:\inetpub\wwwroot\audio\webstats-dist.js:400:23)
    at convertFormattingCodes (x:\inetpub\wwwroot\audio\webstats-dist.js:372:11)
    at updateScoreboard (x:\inetpub\wwwroot\audio\webstats-dist.js:286:26)
    at updateStats (x:\inetpub\wwwroot\audio\webstats-dist.js:309:8)
    at init (x:\inetpub\wwwroot\audio\webstats-dist.js:186:8)
    at init (x:\inetpub\wwwroot\audio\webstats-dist.js:553:16)
    at <anonymous> (x:\inetpub\wwwroot\audio\webstats-dist.js:519:48)
    --- Promise.then ---
    at WebStats (x:\inetpub\wwwroot\audio\webstats-dist.js:519:30)
    at <anonymous> (x:\inetpub\wwwroot\audio\index.html:15:18)
    --- load ---
    at <anonymous> (x:\inetpub\wwwroot\audio\index.html:14:10)

Answer 17 · 2022-08-22T20:38:27.000Z

seems to be that undefined lines in the map could cause the script to crash?

Answer 18 · 2022-08-22T21:03:22.000Z

Whoops, I didn't test it on strings starting with a formatting code. Should be fixed in https://github.com/Dantevg/WebStats/blob/397995b490a7493a7cf6d1b55558a7351950b6b7/web/WebStats-dist.js 😳

Answer 19 · 2022-08-22T21:06:04.000Z

Hey! it works!
🥂

Answer 20 · 2022-08-22T21:09:00.000Z

Whew, nice. Looking good!

Answer 21 · 2022-08-22T21:28:57.000Z

yessir! time to finally get started on the API interface for the profile page lookup system, whenever I find the time 😅