Daohub-io/cap9

Some tests are sensitive to line endings

JakeOShannessy opened this issue · 2 comments

JakeOShannessy commented

The following test fails when the contract code (Simple.sol) have CRLF line endings, but succeed with LF line endings. This is likely because a hash of the Solidity source code is stored in the swarm data (which is naturally sensitive to things like line endings). This should be fixed by trimming the swarm data, which we are doing. It seems either we are not properly trimming the swarm data or this hash information is otherwise included in the bytecode which is being deployed.

Kernel without entry procedure > .executeProcedure(bytes24 key, bytes payload) > should execute > Simple Procedure > X() should fail

Latrasis commented

@JakeOShannessy: Any ideas how I could re-create this? I'm not sure how to trigger CRLF formatting.

JakeOShannessy commented

I've been trying to do that, and it seems to have rectified itself. It was a problem we had before, but it seems to have rectified itself. Perhaps it was another issue that was fixed be me resaving the file. All the tests are passing for me now, which was my primary concern, so I'll close it for now unless it crops up again.

  • 👍1