Darmody/redux-action-types-creator

don't depend on all of lodash

Closed this issue · 3 comments

Hi! I love this module. I was trying to track down some bloat in my app, and found this module may be a culprit. It's importing all of lodash, when it really only needs

import T from 'lodash/fp/stubTrue';
import compose from 'lodash/fp/compose' ;
import concat from 'lodash/fp/concat';
import cond from 'lodash/fp/cond';
import drop from 'lodash/fp/drop';
import equals from 'lodash/fp/equals';
import keys from 'lodash/fp/keys';
import map from 'lodash/fp/map';
import merge from 'lodash/merge'
import placeholder from 'lodash/fp/placeholder';
import set from 'lodash/fp/set';
import split from 'lodash/fp/split';

I think splitting these up might help

here's how i tracked it down:

screen shot 2017-06-05 at 6 27 02 pm

@VinSpee It's happy you like it, and this is really helpful!

I will fix this problem ASAP.

You are the best! I'm looking forward to it.

@VinSpee Fix this in release 1.2.0

Please let me know if you have any problems.