Dasharo/open-source-firmware-validation

ME Disabled (HAP) will no longer affect lspci output

filipleple opened this issue · 5 comments

Device

Novacustom v5x

RTE version

--

OSFV version

9603436

Affected component(s) or functionality

ME-neuter test

Brief summary

ME Disabled (HAP) will no longer affect lspci output, so we need to verify it in some other way.

How reproducible

100%

How to reproduce

Run the MNE004.001 Intel ME mode option Disabled (HAP) works correctly (Ubuntu) case

Expected behavior

It should pass

Actual behavior

It will always fail, since the HAP disabling doesn't affect lspci output anymore - ME will still appear as 00:16.0

Link to screenshots or logs

--

Additional context

No response

Solutions you've tried

No response

We have a change in progress here: #346
But it seems it's been applied to static test, can we apply this to dynamic checks as well @wiktormowinski ?
Perhaps we can have a keyword to check ME state, and reuse it across these tests.

I just did the same in 3 test cases from me-neuter. By ''the same'' i mean the no-keyword version ... for now of course.
Same place:
#346

still working on fix here: #375

If ME is visible, we can check Operation Mode field in HFSTS1. When the HAP bit is set, the ME should go into Debug Mode, indicated by the Current Operation Mode field set to 2.

Or check CBMEM logs:

[DEBUG]  ME: HFSTS1                      : 0x80022054
[DEBUG]  ME: Current Operation Mode      : 2
[INFO ]  HECI: coreboot in recovery mode; found CSE in expected Debug Mode state, skipping EOP

For Soft Disable, the COM value will be 3.

Newest version working on the new Develop branch #403