Dasharo/open-source-firmware-validation

run & regression wrappers split arguments in quotes

philipandag opened this issue · 1 comments

Device

any

RTE version

any

OSFV version

develop

Affected component(s) or functionality

osfv robot wrappers

Brief summary

Running tests with additional arguments will fail if args have values in quotes containing whitespace

How reproducible

100%

How to reproduce

run, for example:
scripts/run.sh dasharo-stablity/power-on-keyword-stress.robot -- -t "*in OS*"

Expected behavior

The tests containing "on OS" in their name should be run

Actual behavior

robot fails due to error in arguments

Link to screenshots or logs

 scripts/run.sh dasharo-stability/power-on-keyword-stress.robot -- -t "in OS"
dasharo-stability/power-on-keyword-stress.robot -- -t in OS
robot -L TRACE -l logs/protectli-vp4630/2024_08_20_08_31_06/dasharo-stability/power-on-keyword-stress.robot__log.html -r logs/protectli-vp4630/2024_08_20_08_31_06/dasharo-stability/power-on-keyword-stress.robot__report.html -o logs/protectli-vp4630/2024_08_20_08_31_06/dasharo-stability/power-on-keyword-stress.robot__out.xml -b logs/protectli-vp4630/2024_08_20_08_31_06/dasharo-stability/power-on-keyword-stress.robot__debug.log -v rte_ip:192.168.10.244 -v config:protectli-vp4630 -t in OS dasharo-stability/power-on-keyword-stress.robot
[ ERROR ] Parsing 'OS' failed: File or directory to execute does not exist.

Additional context

now the scripts remove quotes from args and calling
scripts/run.sh dasharo-stablity/power-on-keyword-stress.robot -- -t "*in OS*"
results in something like
robot (...) -t *in OS* dasharo-stability/power-on-keyword-stress.robot
without quotes the args are not passed properly.

Solutions you've tried

No response

I think I managed to fix it
#465