DataDog/sketches-go

dataset_test.go fails

eclipseo opened this issue · 0 comments

It seems that
dataset_test.go is outdated as MinRank and Maxrank have bee removed from dataset.go:

# github.com/DataDog/sketches-go/dataset [github.com/DataDog/sketches-go/dataset.test]
./dataset_test.go:22:29: d.MinRank undefined (type *Dataset has no field or method MinRank)
./dataset_test.go:23:29: d.MaxRank undefined (type *Dataset has no field or method MaxRank)
./dataset_test.go:24:29: d.MinRank undefined (type *Dataset has no field or method MinRank)
./dataset_test.go:25:29: d.MaxRank undefined (type *Dataset has no field or method MaxRank)
./dataset_test.go:26:29: d.MinRank undefined (type *Dataset has no field or method MinRank)
./dataset_test.go:27:29: d.MaxRank undefined (type *Dataset has no field or method MaxRank)
./dataset_test.go:28:29: d.MinRank undefined (type *Dataset has no field or method MinRank)
./dataset_test.go:29:29: d.MaxRank undefined (type *Dataset has no field or method MaxRank)
./dataset_test.go:30:29: d.MinRank undefined (type *Dataset has no field or method MinRank)
./dataset_test.go:31:29: d.MaxRank undefined (type *Dataset has no field or method MaxRank)
./dataset_test.go:31:29: too many errors
FAIL	github.com/DataDog/sketches-go/dataset [build failed]