DataDog/sketches-go

ProtoReflect method removed from DDSketch, while the lib (protobuf) still depends on it

snedzad opened this issue · 1 comments

snedzad commented

Describe what happened:
Can't refresh packages due to broken dependencies.

Describe what you expected:
github.com/DataDog/sketches-go/ddsketch/pb/sketchpb
github.com/DataDog/sketches-go/ddsketch/mapping
github.com/DataDog/sketches-go/ddsketch/store
github.com/DataDog/sketches-go/ddsketch
gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer
../../../gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer/stats.go:294:33: cannot use msg (type *sketchpb.DDSketch) as type protoreflect.ProtoMessage in argument to "google.golang.org/protobuf/proto".Marshal:
*sketchpb.DDSketch does not implement protoreflect.ProtoMessage (missing ProtoReflect method)
../../../gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer/stats.go:299:34: cannot use msg (type *sketchpb.DDSketch) as type protoreflect.ProtoMessage in argument to "google.golang.org/protobuf/proto".Marshal:
*sketchpb.DDSketch does not implement protoreflect.ProtoMessage (missing ProtoReflect method)

Steps to reproduce the issue:
Remove any DataDog local package.
Re-download the package
Observe errors stating that protoreflect.ProtoMessage implementation is missing.
Go versions used: 1.15 1.16 1.18

CharlesMasson commented

Thanks for reporting. v1.4.1 was released and includes a fix.

  • 👍1