Eradicate negative assertions tests

[simon-id]

Some tests have negative assertions, ie: test that nothing happens. This is not really useful, and it's giving false positives for xpass (easy-wins).
Here is the list I could find:

• system-tests/tests/appsec/test_blocking_addresses.py

  Line 342 in b5c7085

  def test_non_blocking(self):

• system-tests/tests/appsec/test_blocking_addresses.py

  Line 473 in b5c7085

  def test_non_blocking(self):

• system-tests/tests/appsec/test_blocking_addresses.py

  Line 518 in b5c7085

  def test_non_blocking(self):

• system-tests/tests/appsec/test_blocking_addresses.py

  Line 532 in b5c7085

  def test_non_blocking_plain_text(self):

• system-tests/tests/appsec/test_blocking_addresses.py

  Line 571 in b5c7085

  def test_non_blocking(self):

• system-tests/tests/appsec/test_blocking_addresses.py

  Line 597 in b5c7085

  def test_non_blocking(self):

• system-tests/tests/appsec/test_customconf.py

  Line 61 in b5c7085

  def test_no_attack_detected(self):

• system-tests/tests/appsec/api_security/test_schemas.py

  Line 257 in b7914f9

  def test_request_method(self):

[cbeauchesne]

system-tests/tests/appsec/test_customconf.py fixed

[simon-id]

@cbeauchesne the last one in the list

system-tests/tests/appsec/api_security/test_schemas.py

Line 257 in b7914f9

def test_request_method(self):

I have no idea how to fix it :/
We can't test that it's "doing something" before because it's tested in a different scenario. I made a workaround that checks when this test is used and fail directly in the weblog: #2401

[cbeauchesne]

There is nothing in telemetry that tells the feature is implemented, but deactivated ?

[simon-id]

There is nothing in telemetry that tells the feature is implemented, but deactivated ?

I'm guessing if it's implemented, it should be sent in the env config telemetry payload, but I didn't pursue that lead myself as I have no idea how to implement it in the system-test. If you can figure it out, i'll test it for you.