DataDog/uwsgi-dogstatsd

Minor: Readme says dogstatsd-no-workers = true, but output has worker metrics

grayaii opened this issue · 2 comments

The example in the README.md says:
...
dogstatsd-no-workers = true
...

This will begin producing metrics with the prefix defined in the configuration, myapp here:
....
myapp.worker.avg_response_time
myapp.worker.core.exceptions
myapp.worker.core.offloaded_requests
myapp.worker.core.read_errors
myapp.worker.core.requests
myapp.worker.core.routed_requests
myapp.worker.core.static_requests
myapp.worker.core.write_errors
myapp.worker.delta_requests
myapp.worker.failed_requests
myapp.worker.requests
myapp.worker.respawns
myapp.worker.rss_size
myapp.worker.total_tx
myapp.worker.vsz_size

But iff dogstatsd-no-workers = true, that means there shouldn't be any worker.*, right?

Dang. I should have ping'ed @nickwilliams-eventbrite in my original post, who made the commit to begin with :)

We've hit this too, but I'm not sure it is minor; with large numbers of workers, these metrics have very high cardinality tagging which rapidly balloons custom metric costs. We'd really like to turn them off.