Can we remove all commented code from node/src/fixtures.rs?
ayushmishra2005 opened this issue · 5 comments
Can we remove all commented code from this file?
Originally posted by @ayushmishra2005 in #5 (comment)
yes we can remove it.
There are a lot of places where we need to remove commented code. But we should try not to add any new commented code.
This is the new file https://github.com/DataHighway-DHX/DataHighway-Parachain/blob/main/node/src/fixtures.rs where commented code was added.
ok so do we remove all the commented code so we lose all traceability of credits that we should be giving and invest time refactoring so the code is more self explanatory without the code comments? for example comments were removed when moving code from standalone chain to the parachain and then it made it difficult to remember why certain changes were made. i would prefer to leave minimal comments if it makes the code more readable if that's faster than refactoring the code, since it's faster to do that than refactor the code before release
FYI, all the commented code in node/src/fixtures.rs has been removed so i think we can close this. there's a copy of the comments in the standalone repo anyway
@ayushmishra2005 please close if you're happy