DataReply/alertmanager-sns-forwarder

Dockerhub Automated builds

Opened this issue · 6 comments

anthonydahanne commented

Hello!
I think it would help if you could setup a build mechanism such as DockerHub Automated builds to build and publish to Dockerhub the image every time there's a new commit merged.

Here is the documentation: https://docs.docker.com/docker-hub/builds/ ; I've done it a few times, I can help you with that if you want to.

I believe that would greatly simplify image consumption; and no need to worry about publishing the image anymore!
Thank you!

anthonydahanne commented

oh, I just noticed you already have something similar with TravisCI.

Unfortunately, I don't think tag v0.2 hit Dockerhub for some reason...

So I guess my issue is still valid; could be left as is or renamed to instead find out why TravisCI CI does not push to :latest at every master merge and does not push :tag whenever a new tag is pushed

  • 👍2
olgierdg commented

Hi, so it does happen for commits to master, the latest tag gets pushed, but yes it was missing for tag builds. I added this now, I'll keep an eye on it the next release.

  • 🎉1
bogdan-alov commented

@olgierdg When is v0.2 going to be pushed to Dockerhub container registry? I don't see it here -> https://hub.docker.com/r/datareply/alertmanager-sns-forwarder/tags . Cheers

  • 👍1
olgierdg commented

Ok done, I brought the docker push fix to that tag and released it again.

  • 🎉3
anthonydahanne commented

thank you! Shall I close the issue?

chris-free commented

We have an issue with the latest and 0.2 docker hub images.

Those tags aren't using the AWS_ROLE_ARN & AWS_WEB_IDENTITY_TOKEN_FILE for us, but this is fixed by building the image manually for us. This was fixed in a previous commit by bumping the sdk version.

Is there any chance the docker hub images aren't up to date?

I noticed the latest/0.2 both have different file sizes as well.