DaveTCode/confluence-python-lib

tests get installed to site-packages

kevinross opened this issue · 3 comments

kevinross commented

While I don't really have a strong opinion on tests being installed when installing a package, I do mind when they get installed as a top-level package in my site-packages! pip install tests actually will install something.

Might I also recommend a rename of the top-level confluence package? I know it's an ideal name right now but the deprecated xmlrpc library currently has the same name so after a pip install, they'll be stepping on each others' toes on the filesystem.

DaveTCode commented

I'll confess to not knowing I was doing this, do you know off hand how to make that not happen?

As for renaming the package I'm not so sure on that one, it's a fairly annoying breaking api change. How strongly do you feel about it? I don't have a good feel for how widely used this package is so whilst nobody else has complained that might be from a sample size of 10.

ExalDraen commented

Hmm, I can't quite reproduce this, installing confluence-rest-library into a fresh Python 3.7 virtual environment only installs the dependencies specified in install_requires in setup.py, i.e. requests as well as their dependencies:

(conf_venv) alexander.hermes tmp $ pip install confluence-rest-library
Collecting confluence-rest-library
  Downloading https://files.pythonhosted.org/packages/43/65/1d6fb6cb97ab99740b7fb15f8c795b9146edef95a663c17d9a65976471d4/confluence_rest_library-1.2.2-py2.py3-none-any.whl (40kB)
(....)
Installing collected packages: urllib3, chardet, idna, certifi, requests, confluence-rest-library
Successfully installed certifi-2019.9.11 chardet-3.0.4 confluence-rest-library-1.2.2 idna-2.8 requests-2.22.0 urllib3-1.25.6

The site-packages of both the virtual environment and main python installation also didn't get a tests or even pytest package installed into them.

@kevinross can you go into a bit more detail as to steps you took and what the (undesirable) outcome was?

FWIW, based on my reading of setup.py and the setuptools docs the setup_requires and test_requires packages should not be persisted on the system.

JohnAdders commented

integration_tests does seems to be being installed into site-packages. To stop it add "integration_tests" to the excludes list in find_packages in setup.py.

  • 👍1