DavidPacioianu/InkPageIndicator

can the indicators for non current page indicators be just circles with no fill ?? Like "O"

Opened this issue · 3 comments

AvinashChowdary commented
can the indicators for non current page indicators be just circles with no fill ?? Like "O"
leonardo2204 commented

Actually the way it is implemented is not possible.
I'd gladly drop a PR if @DavidPacioianu is ok !

  • 👍3
DavidPacioianu commented

@leonardo2204 That would be great!

leonardo2204 commented

Hey guys, I've had some crazy deadline lately, so I couldn't focus on this, sorry.
Nevertheless, I've some points I'd like to clarify with you:
If you zoom-in on the lib, here is what happens:
screenshot_20160620-171814
screenshot_20160620-171826
screenshot_20160620-171739
screenshot_20160620-171808

So, some points I'd like to clarify:

  • The bezier gets drawn at the middle of the circle, so, if the circle is hollow, should we draw the bezier inside it ? (it would look awkward to me).
  • The cubic effect (as shown on the pics) looks awkward also when zoomed-in. Should this chage or keep it ?

Waiting for your feedbacks !

Thanks