Don't detect "UMU-Latest" in compatibilitytools.d
Closed this issue · 4 comments
UMU-Latest is a symlink to a GE-Proton version in the same folder. It is used by https://github.com/Open-Wine-Components/umu-launcher.
It is not a valid compatibility tool by itself, because it depends on another folder.
Could you make it so UMU-Latest is ignored by ProtonUp-Qt in the compatibility tools list?
Thanks.
I wonder how we might ignore this. I agree that it should be ignored, though I am also conscious that maybe ignoring by folder-name is not the ideal solution.
One solution could be, we could check if a symlink resolves to a compatibility tool in the same folder using os.readlink, which we use in a few places in the codebase already. Essentially we would resolve the symlink and if it points to an already existing compatibility tool, we can skip displaying it. I am not sure how trivial this would be, and could have some performance implications if there are a lot of compatibility tools, but this could be generally useful to do and would resolve this issue.
Probably we can ignore symlinks all together. I don't think Steam supports selecting custom compatibility tools in the Steam Client itself with symlinks. I believe it requires an actual folder in compatibilitytools.d.
Steam should support compatibility tool folders as symlinks, at least it did when I tested a while ago. It even supports compatibilitytools.d being a symlink itself.
This issue can be safely ignored. UMU-Launcher does not use the symlink anymore.